Donchian cross

August 24th, 2012, 09:24 AM

TempletonPeck

@Fat Tails

I recently had a look at this indicator.

When I change the channel lines width only the upper channel line width changes. Is it possible to change the lower channel line width, too?

There is a different color than the ones for strong and weak uptrend where I put the arrow on the chart. Is it because I use the indicator with COBC=false?

if you add the following lines to the code (lines 93,94 and 95), the upper and lower lines should match.

Code

	protected override void OnStartUp()
		{
			if(selectedInput == DonchianInputX.UseHighLow)		
			{
				maxHigh = MAX(High,Period);
				minLow = MIN(Low,Period);
			}
			else
			{
				maxHigh = MAX(Close,Period);
				minLow = MIN(Close,Period);
			}
			donchianMinHigh = double.MaxValue;
			donchianMaxLow = double.MinValue;
			Plots[0].Pen.Width = plot0Width;
			Plots[0].PlotStyle = plot0Style;
			Plots[0].Pen.DashStyle = dash0Style;
			Plots[1].Pen.Width = plot1Width;
			Plots[1].PlotStyle = plot1Style;
			Plots[1].Pen.DashStyle = dash1Style;
			Plots[2].Pen.Width = plot1Width;
			Plots[2].PlotStyle = plot1Style;
			Plots[2].Pen.DashStyle = dash1Style;
		}

August 24th, 2012, 10:36 AM

TempletonPeck

@Fat Tails

I recently had a look at this indicator.

When I change the channel lines width only the upper channel line width changes. Is it possible to change the lower channel line width, too?

There is a different color than the ones for strong and weak uptrend where I put the arrow on the chart. Is it because I use the indicator with COBC=false?

@TempletonPeck: That was a simple omission of 3 lines in OnStartUp(). I cannot tell you the reason for the color issue. Could you let me know, whether it is reproducible and what are the time stamps of those bars?

I wanted to update the indicator anyhow. I have now slightly changed the lables. What I called a weak downtrend (actually I wanted to say weakening downtrend) is now an early uptrend. I think it is easier to understand this way.

Actually the confirmed (main) trend changes from positive to negative, when the upper line comes clear from the maximum value of the lower line during the uptrend. The early trend changes to negative, when the upper line comes clear from the maximum value of the Donchian midline during the uptrend.

Rather than waiting for the confrimed trend to change, you can use the early trend and enter after the first pullback.

I have also extended the options to calculate Donchian Channels. You can now calculate them from High/Low, Close, Typical or Weighted. If you use the Typical Price, you will get faster and smoohter signals compared to those generated from the Close or High/Low. Below is a comparison and the updated indicator.

Feedback welcome.

August 24th, 2012, 11:24 AM

Fat Tails

@TempletonPeck: That was a simple omission of 3 lines in OnStartUp(). I cannot tell you the reason for the color issue. Could you let me know, whether it is reproducible and what are the time stamps of those bars?

I wanted to update the indicator anyhow. I have now slightly changed the lables. What I called a weak downtrend (actually I wanted to say weakening downtrend) is now an early uptrend. I think it is easier to understand this way.

Actually the confirmed (main) trend changes from positive to negative, when the upper line comes clear from the maximum value of the lower line during the uptrend. The early trend changes to negative, when the upper line comes clear from the maximum value of the Donchian midline during the uptrend.

Rather than waiting for the confrimed trend to change, you can use the early trend and enter after the first pullback.

I have also extended the options to calculate Donchian Channels. You can now calculate them from High/Low, Close, Typical or Weighted. If you use the Typical Price, you will get faster and smoohter signals compared to those generated from the Close or High/Low. Below is a comparison and the updated indicator.

Feedback welcome.

Thanks for the update!

The color issue only appears sometimes in realtime when used with COBC=false

Here is a quick example: CL 2Range 17:12:35.

When you reload the chart or apply the indicator again the issue is solved.

August 24th, 2012, 11:39 AM

TempletonPeck

Thanks for the update!

The color issue only appears sometimes in realtime when used with COBC=false

Here is a quick example: CL 2Range 17:12:35.

When you reload the chart or apply the indicator again the issue is solved.

I remember the problem now, only occurs with COBC = false, will fix it later today, when I am back on my main PC... becky:

August 24th, 2012, 04:39 PM

Maybe do someone have d.channel that colors only candles?

Like in Supertrend TS indicator

August 24th, 2012, 06:44 PM

TempletonPeck

Thanks for the update!

The color issue only appears sometimes in realtime when used with COBC=false

Here is a quick example: CL 2Range 17:12:35.

When you reload the chart or apply the indicator again the issue is solved.

@TempletonPeck:

I have now replaced the indicator file in post #12. Large parts of the indicator are changed to comply with COBC = false. Please let me know any observations.

By the way, the bug affected at least 6 other indicators, which I have coded, but nobody ever complained!

August 25th, 2012, 05:40 AM

Eduard

Maybe do someone have d.channel that colors only candles?

Like in Supertrend TS indicator

Added paintbars and an option to remove the channel lines, in case that you just want to see the paintbars. Improved code efficiency as well.

August 25th, 2012, 08:16 AM

Oh!, Vielen Dank

October 4th, 2012, 05:39 PM

I have made a minor update of the Donchian Channel indicator.

The new version allows for displacement and will correctly move the colors along with the displaced plot.

Download: Donchian Channel with Trendfilter

Exported using NT version 7.0.1000.27 This is a generalized version of the Donchian Channel with a few options added: - The Donchian Channel lines can be calculated from High/Low, Close, Typical or Weighted price. With the default option High/Low …

Fat Tails

October 4th, 2012, 06:11 PM

Notifications sent.

Mike

Donchian cross

Discussion in NinjaTrader

Donchian cross