NT7 custom user code causing memory leak

permalink · September 13th, 2012, 03:29 PM

Fat Tails

Also when the paint bars leak you would probably see that on your chart.

@Fat Tails

ROTFLMAO!! Made my day!

permalink · September 18th, 2012, 10:29 PM

Thanks Eman, I too have seen some memory issues with the Momentum bars. Do you have a fix for that yet?
In trying to isolate the problem, I ran the charts normal and all was good. Then I paused the replay and added the Momentum and whamo....mem starts going crazy and NT is not functioning at all. I hate to do a hard NT shutdown, but that is the only way to get it back.

Thx
Bob

eman

as per my potential offending code, i'm trying to get an answer from NinjaTrader directly:
clarify Add() in BarsType - [AUTOLINK]NinjaTrader[/AUTOLINK] Support Forum

this is untested, but if you're still working with MomentumBars, try changing this code (approx line 114):

Code

// close current bar; volume included for on-touch only
UpdateBar(bars, bar.Open, (maxCompare > 0 ? thisClose : bar.High), (minCompare < 0 ? thisClose : bar.Low), thisClose, time, (GapSetting == 3 ? volume : 0), isRealtime);

old code may have been overstating volume. not sure that would cause a leak, per se, but i guess it depends on how the indicator was coded.

you may also want to check this line (approx line 138):

Code

// add new bar; include volume once (except for on-touch), then create phantom bars
AddBar(bars, thisOpen, (maxCompare > 0 ? thisClose : thisOpen), (minCompare < 0 ? thisClose : thisOpen), thisClose, time, (GapSetting != 3 && newBar ? volume : 0), isRealtime);

basically, any reference to bar.Volume is suspect, and those are the only two places where that may have appeared.

the only thing that perplexes me is that volumeCount (used in Kagi, for example) is used for both AddBar() and UpdateBar() calls. so i guess it's possible that UpdateBar() does all kinds of magic under the hood.

best to get a straight answer from the source. working on it.

cheers,
-e

permalink · September 18th, 2012, 11:27 PM

bobc635

Thanks Eman, I too have seen some memory issues with the Momentum bars. Do you have a fix for that yet?
In trying to isolate the problem, I ran the charts normal and all was good. Then I paused the replay and added the Momentum and whamo....mem starts going crazy and NT is not functioning at all. I hate to do a hard NT shutdown, but that is the only way to get it back.

Thx
Bob

@bobc635

What settings are you using?

I use ....

and have had no issues.

permalink · September 19th, 2012, 09:05 AM

Wow...maybe I grabbed an old version.... I am running r589 ( I like having rev controlled indis), so I only have R (I use 5) and Gap Setting (I use 2).... What version are you running?

BTW, my son is in Houston... he loves it...coming to visit in Nov for the F1 race in Austin

Thanks

ThatManFromTexas

@bobc635

What settings are you using?

I use ....

and have had no issues.

permalink · September 19th, 2012, 09:27 AM

bobc635

Wow...maybe I grabbed an old version.... I am running r589 ( I like having rev controlled indis), so I only have R (I use 5) and Gap Setting (I use 2).... What version are you running?

BTW, my son is in Houston... he loves it...coming to visit in Nov for the F1 race in Austin

Thanks

r809

permalink · September 19th, 2012, 10:24 AM

the last version on futures.io (formerly BMT) is r809.

the latest version is r860 but there are no logical changes between r809 and r860 - just the addition of the GPL license so it is free-for-all.

i'm still investigating the memory leak issue but haven't had a chance to fully test the proposed code above to see if that cures the problem.

a new version is due out next week which will include extra public properties (requested by indicator developers), a patch for volume (mentioned previously in this thread), and a few other goodies as time permits.

cheers,
-e

permalink · September 19th, 2012, 01:16 PM

I downloaded the newrt version and it seems to be stable so far...will test it in replay tonight....

Thanks

bobc635

Wow...maybe I grabbed an old version.... I am running r589 ( I like having rev controlled indis), so I only have R (I use 5) and Gap Setting (I use 2).... What version are you running?

BTW, my son is in Houston... he loves it...coming to visit in Nov for the F1 race in Austin

Thanks

ThatManFromTexas

r809

permalink · November 20th, 2016, 07:20 PM

Fat Tails

For every indicator that you install on NinjaTrader the Initialize() section is executed, even when the indicator is not set up on a chart. This means that any indicator, which you have downloaded into bin -> Custom -> Indicator folder can create the problem. A new installation of NinjaTrader has no impact on the problems.

Best you rename your folder Documents -> NinjaTrader 7 to NinjaTrader 7 old (do not delete it, if you just rename it your decision is reversible). NinjaTrader will then create a new clean folder. You will still be able to copy your indicators, chart and workspace templates to the new installation, just instrument settings and session templates will be lost, as they are not stored separately.

Would this slow NT7 down? I downloaded many indicators and coded many others. I prolly have 100-200 or more custom indicators in NT7.

permalink · November 21st, 2016, 09:11 AM

mmaker

Would this slow NT7 down? I downloaded many indicators and coded many others. I prolly have 100-200 or more custom indicators in NT7.

This slows down the compilation process. It also causes an additional waiting time when you add indicators to your chart or when you edit any indicator. It may halt NinjaTrader, if only one of our 200 indicators has a bug in the Initialize() section.

It will not affect the chart while it is running, as the Initialize() section of all indicator is only being executed when a new indicator is added to your chart. Once your chart is up and running, there should be no impact.

permalink · November 21st, 2016, 04:19 PM

Fat Tails

This slows down the compilation process. It also causes an additional waiting time when you add indicators to your chart or when you edit any indicator. It may halt NinjaTrader, if only one of our 200 indicators has a bug in the Initialize() section.

It will not affect the chart while it is running, as the Initialize() section of all indicator is only being executed when a new indicator is added to your chart. Once your chart is up and running, there should be no impact.

Appreciate your response. Also Thanks for your work on SuperTrend.

NT7 custom user code causing memory leak

Discussion in NinjaTrader

NT7 custom user code causing memory leak