How to get number of positive and negative strings?

May 24th, 2011, 12:09 PM

Question is pretty simple and I'm sure it takes two minutes to write the code, but I'm novice in Ninja programming so please help

I need a code to give me the number of strings of winning trades and the number of strings of losing trades in trades executed by my strategy.

Thank you

May 24th, 2011, 07:50 PM

and here is the non working code....

#region Using declarations
using System;
using System.ComponentModel;
using System.Drawing;
using NinjaTrader.Cbi;
using NinjaTrader.Data;
using NinjaTrader.Indicator;
using NinjaTrader.Strategy;
#endregion

namespace NinjaTrader.Strategy
{

[Gui.Design.DisplayName("test")]
public class Test12 : OptimizationType
{
#region variables

private int n;
private int numberOfTrades;
private int numberOfLosingStrings;
private int numberOfWinningStrings;

private double myTrade;
private double myTradeBefore;

#endregion

public override double GetPerformanceValue(SystemPerformance systemPerformance)
{

numberOfTrades = systemPerformance.AllTrades.TradesPerformance.TradesCount;

for ( int n = 0; n < numberOfTrades; n++ )
{
Trade myTrade = systemPerformance.AllTrades[n].ProfitCurrency;
Trade myTradeBefore = systemPerformance.AllTrades[n-1].ProfitCurrency;

if ( myTrade < 0 && myTradeBefore > 0 );
{
numberOfLosingStrings++;
}

if ( myTrade > 0 && myTradeBefore < 0 )
{
numberOfWinningStrings++;
}
}

return numberOfLosingStrings;

}
}
}

May 24th, 2011, 08:36 PM

zokirb

Question is pretty simple and I'm sure it takes two minutes to write the code, but I'm novice in Ninja programming so please help

I need a code to give me the number of strings of winning trades and the number of strings of losing trades in trades executed by my strategy.

Thank you

By "number of strings" do you mean consecutive winners and losers? You can use the TradesPerformance objects MaxConsecXxx.

int myStringOfLosers = Performance.AllTrades.TradesPerformance.MaxConsecLoser;
int myStringOfWinners = Performance.AllTrades.TradesPerformance.MaxConsecWinner;

May 25th, 2011, 07:36 AM

if trades look like this.... "+" is winner and "-" is loser

++ -- ++++ -- ++++++

there would be three strings of winners and two strings of losers. i'm not looking for max consecutive winners but for number of positive consecutive trades

May 27th, 2011, 11:47 PM

zokirb

if trades look like this.... "+" is winner and "-" is loser

++ -- ++++ -- ++++++

there would be three strings of winners and two strings of losers. i'm not looking for max consecutive winners but for number of positive consecutive trades

So basically you would look at the last trade result.

If winner, then increment your _consecutivewinners variable and if a loser then reset your _consecutivewinners variable to 0.

Mike

How to get number of positive and negative strings?

Discussion in NinjaTrader

How to get number of positive and negative strings?